Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sentiment as a dropdown while uploading images #94

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

ishaanxgupta
Copy link
Contributor

solves issue #70 and have created a sentiment.json file which can be easily changed by admins.

Description of your changes:
Add sentiment as dropdown to be selected while uploading images.
added some mock sentiments

WhatsApp Image 2025-02-26 at 22 30 38_4d1e9087

sentiment.mp4

image

Checklist:

Signed-off-by: Ishaan Gupta <ishaankone@gmail.com>
@ishaanxgupta
Copy link
Contributor Author

@pradeeban Please have a look

Signed-off-by: Ishaan Gupta <ishaankone@gmail.com>
@ishaanxgupta
Copy link
Contributor Author

Added responsiveness commit also in this PR as it was a minor bug
solves #95

after:-
image

@pradeeban Please have a look

@pradeeban pradeeban merged commit 32ff45c into KathiraveluLab:dev Feb 27, 2025
@pradeeban
Copy link
Member

neat!

@pradeeban
Copy link
Member

Added responsiveness commit also in this PR as it was a minor bug solves #95

after:- image

@pradeeban Please have a look

As a best practice, if you fix two issues, these must be two different pull requests. (of course, we are a small and new project and we have a bit more freedom. But it is nice to know and follow the version control best practices).

@ishaanxgupta
Copy link
Contributor Author

As a best practice, if you fix two issues, these must be two different pull requests. (of course, we are a small and new project and we have a bit more freedom. But it is nice to know and follow the version control best practices).

Sure will follow this in the future PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants